Funnily enough, there's an answer on Google Answers by omniscientbeing-ga which seems ideal. I'll reword and adjust for here.
The real trick is finding a place that is good for both diving and surfing. I could list
a ton that are good for either or, but it's tough to come up with
places that have surfable waves and good diving that meet your
criteria. That said, here are my suggestions:
Nassau, Bahamas.-- Excellent snorkeling and SCUBA diving. Surf only
if you can charter a boat to take you to the outer reef breaks.
There’s not really surfable waves on the main island of Nausau, but
there are remote reef breaks if you’re willing to pay a charter to
take you there. The diving is easy access. Besides that, night life is
there if you want it, as well as fine dining, gambling and just plain
relaxing on the white sand beaches.Cable Beach is the main beach
tourst area where most of the beach hotels are. English spoken
everywhere, US dollars accepted. U.S. passports are not necessary if
you have an original birth certificate with you as well as a driver
license. You’d probably fly from NY to MIA (Miami Airport or perhaps
Fort Lauderdale) and from their a smaller jet goes to the Nassau. It’s
about a 45 min. flight from Miami to Nassau.
Search Google for “Nassau Bahamas” and you’ll find plenty of info.
“Atlantis” is the fanciest resort there. Nassau Beach Hotel is about
as inexpensive as it gets to stay on the sand. If you stay in a hotel
downtown, out of the main tourism area, it’s much cheaper. Taxis and
Florida Keys Again, fantastic snorkeling and SCUBA diving (John Pennekamp State
Park is there, in Key Largo), but here there is absolutely zero surf.
Diving in the Keys is best in Key Largo and Key West. There is also
some good diving in the middle Keys around Marathon, but you’ll need
an experienced boat captain to take you there. Although there is no surf in the Keys, Sebastian Inlet, on the Florida mainland, is known for good surf, depending on the conditions. It’s about a 6 hour drive north from Key Largo. So, you could conceivably
rent a car and head up there for a day or 2 out of your stay in the Keys.
Search Google for “Florida Keys” and you’ll find plenty of info.
Bermuda - Nice diving. Surg occasionally if the conditions are right. Relatively close to you in NY. To find more details on the surf there, search for “Bermuda surfing” and see what comes up.
North Carolina, Outer Banks—Good diving here offshore, if you go on
the dive charter or “six-pack” boats. Also, there is surf both on the
mainland and the Outer Banks. Close proximity to you in NY. Search Google for “North Carolina Outer Banks diving and surfing”
With a 7 hour flight range, you can make the west coast of the U.S. North of Santa Barabara, California, it gets cold, so if you’re looking for warm, tropical water, this is not the place for you. However, southern California, especially in the Summer, is pretty
warm, with water temps in the low 70s to upper 60s. Catalina Island comes recommended.
Fly from NY to LAX. From LA you can take the express ferries daily to
Catalina for about 80 bucks round trip for both of you. It’s 22 miles
off the LA coast. Fantastic diving, if a little chilly, but with 1\8
to 1\4 inch wetsuites, you’ll be fine. Also, the backside of Catalina
has excellent surf, for the adventurous, and of course LA has reat
surf. Notably, Malibu beach, Zuma beach, El Porto and Palos Verdes,
among other spots. Search Google for both “Catalina Island” and “Los Angeles diving” and
“Los Angeles surfing”
Baja California, Mexico. You could probably fly to San Diego, California, from NY in about 7 hours. From there, you could rent a car and drive south of the border into Mexico for 90 minutes to Ensenada, where both the diving and surfing is great. Water temp similar to Los Angeles and Catalina, some freaky cold currents aside. This would be an adventurous” type of trip, but there are nice hotels there if you choose. Or, you can camp along the beach. Search Google for “Diving and surfing in Baja California, Mexico.”
Again, if you want warm tropical-ness, then Cabo San Lucas is the most
tropical place for you in Baja, but that’s the tip of Baja, a solid 24
hours drive from San Diego.
I hope this gives you some good ideas. Have fun on your trip, and
remember to always dive and surf safely, and don't fly after diving!